alter hydraulic failure mortality logic#28
Merged
mvdebolskiy merged 1 commit intoNorESMhub:noresmfrom Oct 17, 2025
Merged
Conversation
5 tasks
JessicaNeedham
approved these changes
Sep 18, 2025
JessicaNeedham
left a comment
There was a problem hiding this comment.
Thanks @rosiealice this looks like a good and necessary change. Noting that per discussion, this change is similar to PR NGEET#1427 on the FATES NGEET repo but should be brought in here first since it might be a while before that PR is integrated. One minor suggestion to prevent negative hmort.
mvdebolskiy
pushed a commit
that referenced
this pull request
Dec 5, 2025
use site_cmass for nbp output bcs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change to how hydraulic failure mortality is calculated.
Previously, below the threshold, mortality occured at the rate dicated by the mort_scalar_hydrfailure
This lead to behaviour with very abrupt thresholds and no sensitivity to altered soil moisture status in long vs short droughts.
This logic was nver important before because the default hf_sm_threshold parameters were very close to zero. Making them larger brings this mechanism into play.
The function, as all the other mortality functions, is a bit arbitrary and scales mortality to be equal to the mort_scalar_hydrfailure when btran is zero. Below the hf_sm_threshold mortality begins to ramp up as a function of the difference between btran and the threshold.
Description:
Collaborators:
Expectation of Answer Changes:
This will changes answers, in dry places.
The differences introduced by this PR are illustrated here:
https://ns9560k.web.sigma2.no/datalake/diagnostics/noresm/rosief/i2000.f45_f45_mg37.fates-nocomp.beta01.v22i/compare/i2000.f45_f45_mg37.fates-nocomp.beta01.v22h/
Here for example is the change in LAI, which as anticipated is mostly in semi arid regions. The magnitude of the effect depends on the settings for the relevant parameters (these are largely unknown, and part of the purpose of FATES is to introduce and expose these types of mortality mechanisms to validation and calibration).
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: